Implement sizebytes for things in the tf transform cache #12038
Merged
+130
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsseW
added
📺 re_viewer
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements memory size tracking for the transform cache by adding SizeBytes trait implementations to various transform-related types, enabling their memory usage to appear in the memory panel.
Key Changes:
- Added
SizeBytesimplementations for transform cache structures - Added
glam::DAffine3to the list of primitive types with size tracking - Connected transform cache memory reporting to use the new size tracking
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/viewer/re_view_spatial/src/caches/transform_database_store.rs | Implements SizeBytes for TransformDatabaseStoreCache and updates memory_report to use the new size tracking |
| crates/utils/re_byte_size/src/primitive_sizes.rs | Adds SizeBytes implementation for glam::DAffine3 type |
| crates/utils/re_byte_size/Cargo.toml | Adds glam workspace dependency |
| crates/store/re_tf/src/transform_resolution_cache.rs | Implements SizeBytes for multiple transform-related types including TransformResolutionCache, ParentFromChildTransform, CachedTransformsForTimeline, CachedTransformValue, TransformsForChildFrameEvents, TransformsForChildFrame, and ResolvedPinholeProjection |
| crates/store/re_tf/src/frame_id_registry.rs | Implements SizeBytes for FrameIdRegistry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Wumpf
requested changes
Dec 2, 2025
Member
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
plz do struct deconstruction, see comment
thx!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Implements size bytes for the transform cache so its memory usage shows up in the memory panel.